-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Score documents widget #632
Conversation
Here is the workflow to test the widget |
The widget currently doesn't output anything. Probably, it should output a table with scores? :) |
87c48ed
to
13cf312
Compare
Today at the meeting we decided to change the following:
|
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 71.29% 71.97% +0.67%
==========================================
Files 66 70 +4
Lines 7806 8634 +828
Branches 1027 1156 +129
==========================================
+ Hits 5565 6214 +649
- Misses 2038 2203 +165
- Partials 203 217 +14 |
816dfe0
to
d7fe564
Compare
f6db6a4
to
0b4f31c
Compare
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 73.37% 74.01% +0.63%
==========================================
Files 70 71 +1
Lines 8898 9159 +261
Branches 1191 1238 +47
==========================================
+ Hits 6529 6779 +250
- Misses 2137 2144 +7
- Partials 232 236 +4 |
box, | ||
self, | ||
"aggregation", | ||
searchable=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I woudl not make the combo searchable for only four items.
callback=self.__setting_changed, | ||
) | ||
|
||
box = gui.widgetBox(self.controlArea, "Aggregate scores") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Aggregate scores" -> "Aggregation" to make it consistent with the Extract Keywords
widget
One can select rows in the table, but the selection is not reflected in the output. |
Issue
Implements #631
Description of changes
Score documents widget
Includes